Skip to content

Conversation

@sebix
Copy link
Member

@sebix sebix commented Jan 10, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #2136 (ddc4d35) into develop (bfcdbad) will decrease coverage by 0.02%.
The diff coverage is 47.19%.

@@             Coverage Diff             @@
##           develop    #2136      +/-   ##
===========================================
- Coverage    75.93%   75.91%   -0.03%     
===========================================
  Files          440      440              
  Lines        23630    23604      -26     
  Branches      3439     3434       -5     
===========================================
- Hits         17943    17918      -25     
+ Misses        4956     4955       -1     
  Partials       731      731              
Impacted Files Coverage Δ
...lmq/bin/intelmq_generate_misp_objects_templates.py 0.00% <0.00%> (ø)
intelmq/bin/intelmqdump.py 18.30% <0.00%> (ø)
intelmq/bin/intelmqsetup.py 0.00% <ø> (ø)
intelmq/bin/rewrite_config_files.py 0.00% <ø> (ø)
intelmq/bots/collectors/file/collector_file.py 63.04% <ø> (ø)
intelmq/bots/collectors/kafka/collector.py 51.85% <0.00%> (ø)
intelmq/bots/collectors/tcp/collector.py 84.31% <0.00%> (ø)
...telmq/bots/collectors/twitter/collector_twitter.py 37.68% <ø> (ø)
intelmq/bots/experts/aggregate/expert.py 90.90% <ø> (-0.17%) ⬇️
intelmq/bots/experts/asn_lookup/expert.py 34.67% <0.00%> (ø)
... and 93 more
Copy link
Contributor

@waldbauer-certat waldbauer-certat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the removal of "opening modes" at those files. It could lead to not intended behaviour.

@waldbauer-certat waldbauer-certat self-requested a review January 28, 2022 10:37
@sebix sebix added this to the 3.1.0 milestone Jan 28, 2022
@sebix sebix self-assigned this Jan 28, 2022
@sebix sebix merged commit 651d073 into certtools:develop Jan 28, 2022
@sebix sebix deleted the pyupgrade36 branch May 23, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants