ENH: Added personal access token support to GitHub Collector

[waldbauer-certat]

As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

[codecov-commenter]

Codecov Report

Merging #2145 (ed819e9) into develop (79cae29) will decrease coverage by 0.11%.
The diff coverage is 60.00%.

❗ Current head ed819e9 differs from pull request most recent head 2a4beaf. Consider uploading reports for the commit 2a4beaf to get more accurate results

@@             Coverage Diff             @@
##           develop    #2145      +/-   ##
===========================================
- Coverage    76.34%   76.23%   -0.12%     
===========================================
  Files          441      441              
  Lines        23654    23628      -26     
  Branches      3739     3437     -302     
===========================================
- Hits         18059    18012      -47     
- Misses        4858     4879      +21     
  Partials       737      737              

Impacted Files	Coverage Δ
...tests/bots/collectors/github_api/test_collector.py	100.00% <ø> (ø)
...ots/collectors/github_api/_collector_github_api.py	75.86% <60.00%> (-3.55%)	⬇️
intelmq/bots/experts/reverse_dns/expert.py	83.87% <0.00%> (-11.30%)	⬇️
intelmq/bots/experts/mcafee/expert_mar.py	35.55% <0.00%> (-8.89%)	⬇️
intelmq/bots/parsers/dshield/parser_domain.py	95.45% <0.00%> (-4.55%)	⬇️
intelmq/bots/collectors/opendxl/collector.py	30.15% <0.00%> (-3.18%)	⬇️
intelmq/bots/experts/modify/expert.py	94.66% <0.00%> (-2.67%)	⬇️
intelmq/bots/parsers/dshield/parser_block.py	87.50% <0.00%> (-2.50%)	⬇️
intelmq/bots/collectors/tcp/collector.py	84.31% <0.00%> (-1.97%)	⬇️
intelmq/bots/parsers/generic/parser_csv.py	85.18% <0.00%> (-1.86%)	⬇️
... and 14 more

[sebix]

Please add a note to the NEWS file on the parameter change

https://developer.github.com/changes/2020-02-14-deprecating-password-auth/#removal says:

All password authentication will return a status code of 401 starting:

November 13, 2020 at 16:00 UTC

So I guess the old auth does no longer work? If that's the case, please remove the old method, it's of no use.

the feeds.yml needs an update as well: https://intelmq.readthedocs.io/en/latest/user/feeds.html#id123

[waldbauer-certat]

Please add a note to the NEWS file on the parameter change

https://developer.github.com/changes/2020-02-14-deprecating-password-auth/#removal says:

All password authentication will return a status code of 401 starting:

November 13, 2020 at 16:00 UTC

So I guess the old auth does no longer work? If that's the case, please remove the old method, it's of no use.

the feeds.yml needs an update as well: https://intelmq.readthedocs.io/en/latest/user/feeds.html#id123

Feeds will be auto build, no? Because its gitignored https://github.com/certtools/intelmq/blob/develop/.gitignore#L30

[sebix]

So I guess the old auth does no longer work? If that's the case, please remove the old method, it's of no use.
the feeds.yml needs an update as well: https://intelmq.readthedocs.io/en/latest/user/feeds.html#id123

Feeds will be auto build, no? Because its gitignored https://github.com/certtools/intelmq/blob/develop/.gitignore#L30

That page is generated from intelmq/etc/feeds.yml

[sebix]

And:

==================================== ERRORS ====================================
______ ERROR at setup of test_collector_should_fail_with_bad_credentials _______
file /home/runner/work/intelmq/intelmq/intelmq/tests/bots/collectors/github_api/test_collector.py, line 96
  @patch('intelmq.bots.collectors.github_api.collector_github_contents_api.requests.get')
  def test_collector_should_fail_with_bad_credentials(self, requests_get_mock):
E       fixture 'requests_get_mock' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, requests_mock, time_machine, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.
/home/runner/work/intelmq/intelmq/intelmq/tests/bots/collectors/github_api/test_collector.py:96
---------- coverage: platform linux, python 3.7.13-final-0 -----------
Coverage XML written to file coverage.xml
=========================== short test summary info ============================
ERROR intelmq/tests/bots/collectors/github_api/test_collector.py::test_collector_should_fail_with_bad_credentials

[sebix]

As you are keen on codestyle and "Quality of Life": Before a class statement there should be two empty lines ;)