Skip to content

pkg: add requests_mock as dev dependency #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebix merged 1 commit into from
Jul 6, 2022
Merged

pkg: add requests_mock as dev dependency #2210

sebix merged 1 commit into from
Jul 6, 2022

Conversation

@sebix
Copy link
Member

@sebix sebix commented Jul 6, 2022

Add test dependency requests_mock to the development extra requirements in setup.py
@sebix sebix requested a review from waldbauer-certat July 6, 2022 08:07
@sebix sebix added bug Indicates an unexpected problem or unintended behavior packaging labels Jul 6, 2022
@sebix sebix added this to the 3.1.0 milestone Jul 6, 2022
waldbauer-certat
waldbauer-certat approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@waldbauer-certat waldbauer-certat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@sebix
pkg: add requests_mock as dev dependency
91070dd 
Add test dependency `requests_mock` to the `development` extra requirements in `setup.py`
@sebix sebix force-pushed the fix-setup-extra-dev branch from b003f9f to 91070dd Compare July 6, 2022 09:36
@sebix
Copy link
Member Author

sebix commented Jul 6, 2022

rebased on develop
@sebix sebix merged commit 5c770e1 into develop Jul 6, 2022
@sebix sebix deleted the fix-setup-extra-dev branch July 6, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Indicates an unexpected problem or unintended behavior packaging

3 participants

@sebix @waldbauer-certat