Skip to content

Fixes #10#11

Merged
njoubert-cleverage merged 10 commits into
mainfrom
feature/upgrade-sf-php
Dec 9, 2025
Merged

Fixes #10#11
njoubert-cleverage merged 10 commits into
mainfrom
feature/upgrade-sf-php

Conversation

@xaviermarchegay

Copy link
Copy Markdown
Member
  • upgrade composer.json
  • Dockerfile (opcache is part of php now)
  • upgrade versions in github actions

Description

Upgrades php and symfony

Requirements

  • Documentation updates
    • Reference
    • Changelog
  • Unit tests
* upgrade composer.json
* Dockerfile (opcache is part of php now)
* upgrade versions in github actions

@njoubert-cleverage njoubert-cleverage Dec 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xaviermarchegay .github/workflows/test.yml must be updated too.

@njoubert-cleverage

Copy link
Copy Markdown
Member

Please upgrade Rector & php-cs-fixer config too.

* upgrade test.yml
* upgrade minimum php version in composer.json
* add parallel run in phpcsfixer
* remove @PHP71Migration in phpcsfixer
* upgrade php version in rector
* fix test.yml
* remove php8.5
* upgrade phpunit configuration file
* upgrade phpunit configuration file
Comment thread .github/workflows/test.yml Outdated

symfony-require: 7.4.*
variant: symfony/symfony:"7.4.*"
# - php-version: '8.4'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment it

# allowed-to-fail: false
# symfony-require: 8.0.*
# variant: symfony/symfony:"8.0.*"
- php-version: '8.5'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add - php-version: '8.5'
dependencies: highest
allowed-to-fail: false
symfony-require: 6.4.*
variant: symfony/symfony:"6.4.*"

Comment thread .github/workflows/test.yml Outdated
allowed-to-fail: false
symfony-require: 7.4.*
variant: symfony/symfony:"7.4.*"
# - php-version: '8.5'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment it

Comment thread .php-cs-fixer.dist.php Outdated
EOF;

return (new PhpCsFixer\Config())
->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect())

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete it

Comment thread .github/workflows/test.yml Outdated
# - php-version: '8.4'
# dependencies: highest
# allowed-to-fail: false
# symfony-require: 8.0.*

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try symfony-require: 8.*
variant: symfony/symfony:"8.*"

Comment thread rector.php Outdated
// here we can define what prepared sets of rules will be applied
->withPreparedSets(deadCode: true, codeQuality: true, symfonyCodeQuality: true)
->withAttributesSets(symfony: true)
->withComposerBased(symfony: true)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work on vendors because symfony version is multiple.

* Remove `withComposerBased` from Rector config
* Simplify `.php-cs-fixer.dist.php` by removing `setParallelConfig`
* Update `symfony/cache` constraint in `composer.json`
* Revise GitHub Actions workflow to add support for PHP 8.4 and 8.5
* Update CHANGELOG for v2.0 release
Comment thread composer.json Outdated
"require": {
"php": ">=8.2",
"cleverage/process-bundle": "^4.0",
"cleverage/process-bundle": "^4.0|^5.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only latest version of PB is supported. => "cleverage/process-bundle": "^5.0",

Comment thread CHANGELOG.md Outdated

### Changes
* [#10](https://github.com/cleverage/cache-process-bundle/issues/10) Add support for PHP 8.5 and Symfony 8.* Update phpunit/phpunit to version >10.0
* [#10](https://github.com/cleverage/cache-process-bundle/issues/10) Add support for PHP 8.5 and Symfony 8.* Update phpunit/phpunit to version >10.0 Add support for cleverage/process-bundle ^5.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support for cleverage/process-bundle ^5.0 => Bump version to cleverage/process-bundle ^5.0

@njoubert-cleverage njoubert-cleverage merged commit 24e3123 into main Dec 9, 2025
17 of 34 checks passed
@njoubert-cleverage njoubert-cleverage deleted the feature/upgrade-sf-php branch December 9, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants