Render arrays correctly in SQL#3945
Closed
mamcx wants to merge 1 commit into
Closed
Conversation
egormanga
reviewed
Jan 14, 2026
| let mut ty = &*value.ty().elem_ty; | ||
| loop { | ||
| // We're doing this because of `Ref`s. | ||
| break match (value.value(), ty) { |
Contributor
There was a problem hiding this comment.
Do we have to replicate this code in two to three places? Maybe at least add comments pointing to other places then.
But I think it can be implemented in a common trait.
egormanga
reviewed
Jan 14, 2026
| }; | ||
| ctx.db.t_others().insert(tuple.clone()); | ||
| ctx.db.t_others_tuple().insert(TOthersTuple { tuple }); | ||
|
|
Contributor
There was a problem hiding this comment.
nit: there's an unstripped indentation left here
Contributor
Still doesn't work correctly in |
Contributor
Contributor
|
Needs to be reimplemented because of the out of date smoketest. |
cloutiertyler
added
the
close-stale-pr-create-issue
Contributor
|
Closing this stale PR in favor of #4825, which tracks reimplementing the work on top of current |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
As the title says.
API and ABI breaking changes
Before arrays incorrectly display and only for the first item.
Expected complexity level and risk
1
Testing
psql