Skip to content

Implemented FilterableValue for Option<FilterableValue> #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
egormanga wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implemented FilterableValue for Option<FilterableValue> #4013

egormanga wants to merge 1 commit into from

Conversation

@egormanga
Copy link
Contributor

@egormanga egormanga commented Jan 12, 2026

Description of Changes

API and ABI breaking changes

None.

Expected complexity level and risk

1.

Testing

  • Manual testing
  • Unit tests
@bfops
Copy link
Collaborator

bfops commented Jan 13, 2026

Hey @egormanga, thank you for creating this.

Unfortunately, the full scope of FilterableValue is more expansive than it may first appear. See the augmented docs in https://github.com/clockworklabs/SpacetimeDB/pull/4024/files#diff-3ce7e5c02154d19ebe0624a457ea8b0c30a6b1658a24856ed1ea2ec3ee28916a.
@egormanga
Copy link
Contributor Author

egormanga commented Jan 14, 2026

@bfops I assume this means that for Option<T> specifically we need to add special handling on the clients? JS will, for sure, treat and compare it as an object.
@egormanga egormanga mentioned this pull request Jan 15, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@egormanga @bfops