Use the normal shutdown path for the standalone integration tests#5350
Merged
Conversation
joshua-spacetime
force-pushed
the
joshua/test/clean-shutdown
branch
from
0792a32 to
e33fe8a
Compare
joshua-spacetime
force-pushed
the
joshua/test/clean-shutdown
branch
from
e33fe8a to
219cf7f
Compare
kim
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is an attempt at fixing a SIGABRT that sometimes happens when running the standalone integration tests.
It's not clear exactly what causes it, however one thing that may have contributed to it was that previously the tests did not initiate a clean shutdown of the database.
Some modules schedule repeating work in
init, and it's not obvious to me that in flight operations will exit cleanly if we just drop all of the database/runtime handles at once.API and ABI breaking changes
N/A
Expected complexity level and risk
1
Testing
This is a testing fix.