Skip to content

Conversation

pombosilva
Copy link
Contributor

@pombosilva pombosilva commented Sep 26, 2025

Fixes WOR-925.

Workflow names and instance IDs were not being validated in dev. Now they match production behavior.

  • Workflow name is now properly verified in wrangler
  • Workflow instance ID is now verified in workflows-shared
Copy link

changeset-bot bot commented Sep 26, 2025

🦋 Changeset detected

Latest commit: bbf72d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cloudflare/workflows-shared Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pombosilva pombosilva force-pushed the osilva/fix-workflows-instance-id branch from 1dabbea to d8896bb Compare September 26, 2025 14:08
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 26, 2025
@pombosilva pombosilva marked this pull request as ready for review September 26, 2025 14:08
@pombosilva pombosilva requested review from a team as code owners September 26, 2025 14:08
Copy link

pkg-pr-new bot commented Sep 26, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10785

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10785

miniflare

npm i https://pkg.pr.new/miniflare@10785

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10785

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10785

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10785

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10785

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10785

wrangler

npm i https://pkg.pr.new/wrangler@10785

commit: bbf72d0

@pombosilva pombosilva force-pushed the osilva/fix-workflows-instance-id branch from d8896bb to e0044ea Compare September 26, 2025 14:14
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main osilva/fix-workflows-instance-id might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10785
  • add the skip-v3-pr label to the current PR to stop this workflow from failing
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 26, 2025
@pombosilva pombosilva force-pushed the osilva/fix-workflows-instance-id branch 4 times, most recently from 08c4dfc to e06ecca Compare September 26, 2025 16:26
@pombosilva pombosilva force-pushed the osilva/fix-workflows-instance-id branch from e06ecca to bbf72d0 Compare September 26, 2025 17:23
@petebacondarwin petebacondarwin added the skip-v3-pr Skip validation of presence of a v3 backport PR label Sep 27, 2025
@petebacondarwin petebacondarwin merged commit d09cab3 into main Sep 27, 2025
40 of 42 checks passed
@petebacondarwin petebacondarwin deleted the osilva/fix-workflows-instance-id branch September 27, 2025 11:07
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

3 participants