Skip to content

Conversation

cmackenzie1
Copy link
Contributor

Some field validation has been moved to the client side for more immediate feedback.

./bin/wrangler.js pipelines setup

 ⛅️ wrangler 4.40.3
───────────────────
▲ [WARNING] 🚧 `wrangler pipelines setup` is an open-beta command. Please report any issues to https://github.com/cloudflare/workers-sdk/issues/new/choose

🚀 Welcome to Cloudflare Pipelines Setup!
This will guide you through creating a complete pipeline: stream → pipeline → sink

✔ What would you like to name your pipeline? … this-a-test

✘ [ERROR] Pipeline name must contain only letters, numbers, and underscores

Fixes PIPE-391


  • Tests
    • Tests included
    • Tests not necessary because: validation change
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: validation change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: Only supported in v4.
@cmackenzie1 cmackenzie1 requested a review from a team as a code owner September 30, 2025 23:25
Copy link

changeset-bot bot commented Sep 30, 2025

🦋 Changeset detected

Latest commit: 2c9bb4f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main cole/PIPE-391-pipelines-errors might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10833
  • add the skip-v3-pr label to the current PR to stop this workflow from failing
Copy link

pkg-pr-new bot commented Sep 30, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10833

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10833

miniflare

npm i https://pkg.pr.new/miniflare@10833

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10833

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10833

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10833

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10833

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10833

wrangler

npm i https://pkg.pr.new/wrangler@10833

commit: 2c9bb4f

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 2, 2025
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there also be a test change here?

@github-project-automation github-project-automation bot moved this from Approved to In Review in workers-sdk Oct 2, 2025
Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this change?

},
},
validateArgs: (args) => {
validateEntityName("sink", args.sink);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validateEntityName throws an UserError, but it should throw a CommandLineArgsError when used in validateArgs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@cmackenzie1 cmackenzie1 force-pushed the cole/PIPE-391-pipelines-errors branch from b4daa2c to 06e9776 Compare October 2, 2025 16:14
Some field validation has been moved to the client side for more immediate feedback.

```
./bin/wrangler.js pipelines setup

 ⛅️ wrangler 4.40.3
───────────────────
▲ [WARNING] 🚧 `wrangler pipelines setup` is an open-beta command. Please report any issues to https://github.com/cloudflare/workers-sdk/issues/new/choose

🚀 Welcome to Cloudflare Pipelines Setup!
This will guide you through creating a complete pipeline: stream → pipeline → sink

✔ What would you like to name your pipeline? … this-a-test

✘ [ERROR] Pipeline name must contain only letters, numbers, and underscores
```
@cmackenzie1 cmackenzie1 force-pushed the cole/PIPE-391-pipelines-errors branch from 2d061a9 to 2c9bb4f Compare October 2, 2025 16:35
@edmundhung edmundhung added the skip-v3-pr Skip validation of presence of a v3 backport PR label Oct 6, 2025
@github-project-automation github-project-automation bot moved this from In Review to Approved in workers-sdk Oct 6, 2025
@petebacondarwin petebacondarwin merged commit 196ccbf into main Oct 6, 2025
48 of 50 checks passed
@petebacondarwin petebacondarwin deleted the cole/PIPE-391-pipelines-errors branch October 6, 2025 13:37
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

4 participants