-
Notifications
You must be signed in to change notification settings - Fork 1k
PIPE-391: Better error messages and client-side validation #10833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2c9bb4f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there also be a test change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this change?
}, | ||
}, | ||
validateArgs: (args) => { | ||
validateEntityName("sink", args.sink); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validateEntityName
throws an UserError, but it should throw a CommandLineArgsError
when used in validateArgs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
b4daa2c
to
06e9776
Compare
Some field validation has been moved to the client side for more immediate feedback. ``` ./bin/wrangler.js pipelines setup ⛅️ wrangler 4.40.3 ─────────────────── ▲ [WARNING] 🚧 `wrangler pipelines setup` is an open-beta command. Please report any issues to https://github.com/cloudflare/workers-sdk/issues/new/choose 🚀 Welcome to Cloudflare Pipelines Setup! This will guide you through creating a complete pipeline: stream → pipeline → sink ✔ What would you like to name your pipeline? … this-a-test ✘ [ERROR] Pipeline name must contain only letters, numbers, and underscores ```
2d061a9
to
2c9bb4f
Compare
Some field validation has been moved to the client side for more immediate feedback.
Fixes PIPE-391