Skip to content

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 2, 2025

Removes node:os platform() call in favor of process.platform


  • Tests
    • Tests included
    • Tests not necessary because: does not change behavior
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: internal change
@anonrig anonrig requested a review from a team as a code owner October 2, 2025 20:57
@anonrig anonrig added the skip-v3-pr Skip validation of presence of a v3 backport PR label Oct 2, 2025
Copy link

changeset-bot bot commented Oct 2, 2025

🦋 Changeset detected

Latest commit: 47fc6bb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 2, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10856

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10856

miniflare

npm i https://pkg.pr.new/miniflare@10856

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10856

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10856

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10856

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10856

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10856

wrangler

npm i https://pkg.pr.new/wrangler@10856

commit: 47fc6bb

@anonrig anonrig force-pushed the yagiz/get-rid-of-node-os branch from c87b442 to 5d1a9d7 Compare October 2, 2025 21:02
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 3, 2025
@edmundhung edmundhung force-pushed the yagiz/get-rid-of-node-os branch from 5d1a9d7 to 47fc6bb Compare October 6, 2025 12:34
@edmundhung edmundhung merged commit 1334102 into main Oct 6, 2025
45 of 49 checks passed
@edmundhung edmundhung deleted the yagiz/get-rid-of-node-os branch October 6, 2025 15:49
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

3 participants