Skip to content

Don't check expiry dates on custom certs #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Don't check expiry dates on custom certs #6051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/chatty-candles-smoke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"wrangler": patch
---

Don't check expiry dates on custom certs

Fixes https://github.com/cloudflare/workers-sdk/issues/5964

For `wrangler dev`, we don't have to check whether certificates have expired when they're provided by the user.
4 changes: 1 addition & 3 deletions packages/wrangler/src/https-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ export function getHttpsOptions(
"Missing Custom Certificate File at " + customHttpsCertPath
);
}
if (hasCertificateExpired(customHttpsKeyPath, customHttpsCertPath)) {
throw new UserError("Custom Certificate is invalid");
}

logger.log("Using custom certificate at ", customHttpsKeyPath);

return {
Expand Down