-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add Waku to C3 #8314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Waku to C3 #8314
Conversation
🦋 Changeset detectedLatest commit: 14de58a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8aa5ca3
to
d1ff8ba
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-wrangler-8314 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8314/npm-package-wrangler-8314 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-wrangler-8314 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-bindings-extension-8314 -O ./cloudflare-workers-bindings-extension.0.0.0-veb635466b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-veb635466b.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-create-cloudflare-8314 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-kv-asset-handler-8314 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-miniflare-8314 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-pages-shared-8314 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-unenv-preset-8314 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-vite-plugin-8314 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-vitest-pool-workers-8314 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-editor-shared-8314 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workers-shared-8314 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13699747655/npm-package-cloudflare-workflows-shared-8314 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
0f68d70
to
ce7fa61
Compare
@@ -0,0 +1,24 @@ | |||
#:schema node_modules/wrangler/config-schema.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you be able to make this a wrangler.jsonc? for consistency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! I didn't see that the other templates started migrating. I'll get that updated in the Cloudflare Waku template and also rebase to fix the new conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. That is all set in this PR. I also submitted an upstream PR to switch to wrangler.jsonc and to recognize an existing toml, json or jsonc file. wakujs/waku#1301
ce7fa61
to
9d9952b
Compare
Cloudflare is using jsonc as the default config format for their templates: [workers-sdk#8314](cloudflare/workers-sdk#8314 (review)). https://developers.cloudflare.com/workers/wrangler/configuration/
Sorry this has sat here for a while. Would you mind resolving the conflicts? |
853784c
to
d3cb44a
Compare
No problem. Thank you for looking at it. I think this is ready for review. |
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-wrangler-8314 Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-workers-bindings-extension-8314 -O ./cloudflare-workers-bindings-extension.0.0.0-vc581b4f4c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc581b4f4c.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-create-cloudflare-8314 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-kv-asset-handler-8314
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-miniflare-8314
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-pages-shared-8314
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-unenv-preset-8314
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-vite-plugin-8314
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-vitest-pool-workers-8314
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-workers-editor-shared-8314
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-workers-shared-8314
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14462527551/npm-package-cloudflare-workflows-shared-8314 Note that these links will no longer work once the GitHub Actions artifact expires. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for the most part! thanks for your patience, hopefully we can get this out soon 🧡
would you be able to add a changeset, fix the tests and run pnpm fix
to fix the linting issues? let me know if you'd like a hand with any of these :)
packages/create-cloudflare/e2e-tests/frameworks/framework-test-config.ts
Outdated
Show resolved
Hide resolved
899784f
to
3f57a0a
Compare
7e9890a
to
8431f5d
Compare
Fixes cloudflare#7594. Adding a C3 template for Waku, a minimal React framework. https://waku.gg/ - Tests - [ ] TODO (before merge) - [x] Tests included - [ ] Tests not necessary because: - E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately) - [ ] I don't know - [x] Required - [ ] Not required because: - Public documentation - [ ] TODO (before merge) - [x] Cloudflare docs PR(s): <cloudflare/cloudflare-docs#20444> - [ ] Documentation not necessary because:
8431f5d
to
1c28fc1
Compare
I've been trying to land this over the weekend.
|
I will look into it @petebacondarwin. I haven't encountered that build error before. First thing we can try is updating |
Updating create-waku did not seem to fix it. I am reproducing the error running the e2e test locally using
When I run that command, it seems to wait forever on the
But if I So I'm not exactly sure why it is failing with e2e. It looks like the default node version on my machine right now is v22.12.0. |
I'll take a look... |
I can reproduce the error in e2e locally. But also create a new project locally that works. Same as you. I am using Node 20. |
I compared environment variables and found that |
Congratulations @rmarscher, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmg5k2y2i0024l704mur2mxvs This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Fixes #7594.
Adding a C3 template for Waku, a minimal React framework. https://waku.gg/