This repository was archived by the owner on Aug 3, 2023. It is now read-only.
Remove ServiceWorkerAssets::new #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
force-pushed
the
jnelson/remove-assets-new
branch
2 times, most recently
from
cfff041 to
4809583
Compare
nataliescottdavidson
approved these changes
Jul 23, 2021
|
I did a squash-and-merge on my PR (figured my little fixups didn't belong in the history), so you'll have to rebase this. |
jyn514
force-pushed
the
jnelson/remove-assets-new
branch
from
4809583 to
ec48eff
Compare
|
Sure thing, done. |
jyn514
force-pushed
the
jnelson/remove-assets-new
branch
from
ec48eff to
aaac446
Compare
It was almost exactly the same as the struct initializer, and it added a lot of boilerplate. To avoid repeating the `filesystem_to_path` code everywhere, this changes `script_name()` to load the name on-demand.
jyn514
force-pushed
the
jnelson/remove-assets-new
branch
from
aaac446 to
876ab8f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was almost exactly the same as the struct initializer, and it added a lot of
boilerplate. To avoid repeating the
filesystem_to_pathcode everywhere, thischanges
script_name()to load the name on-demand.This builds on #2009 and should not be merged before.