Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…cript, adding dev mode warnings
Baroshem
approved these changes
Oct 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
# [1.1.0](v1.0.7...v1.1.0) (2024-10-01) ### Features * Fixes JS Render Blocking ([#34](#34)) ([eb3a8ff](eb3a8ff))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the CldVideoPlayer and CldUploadWidget components to dynamically load the external scripts to allow for asynchronous loading while being able to easily detect when the script has actually loaded.
It seems this isn't easily possible without some sort of polling solution with the native <script> tag to take advantage of
asyncloading strategy.This also adds some dev warnings to amke it easier to debug why it may not have loaded, including not nesting a inside of CldUploadWidget.
Issue Ticket Number
Fixes #30
Type of change
Checklist