backup: implement online restore in distsql flow #162100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
dt
force-pushed
the
restore-unification
branch
from
de5c6c1 to
997baba
Compare
dt
requested review from
andrew-r-thomas and
msbutler
and removed request for
a team
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
dt
force-pushed
the
restore-unification
branch
from
997baba to
00b97e2
Compare
This implements online restore using the normal restore distsql flow, rather than the bespoke online restore paths used in its initial prototype. This is behind a setting for now, but eventually could be the basis for extending online restore -- now unified with regular restore -- to support ingesting rather than linking some data (such as revision-history layers). Release note: none. Epic: none.
dt
force-pushed
the
restore-unification
branch
from
00b97e2 to
56dbb7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements online restore using the normal restore distsql flow, rather than the bespoke online restore paths used in its initial prototype. This is behind a setting for now, but eventually could be the basis for extending online restore -- now unified with regular restore -- to support ingesting rather than linking some data (such as revision-history layers).
Release note: none.
Epic: none.