-
Notifications
You must be signed in to change notification settings - Fork 39
docs: add Flake8, PHPMD, PHPCS to template & reference (#428) #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add Flake8, PHPMD, PHPCS to template & reference (#428) #429
Conversation
WalkthroughThe documentation was updated to add Flake8, PHPMD, and PHPCS as configurable static analysis tools in both the configuration reference and YAML template. A new guide for Flake8 was also introduced. No changes were made to code, APIs, or exported entities; all modifications are limited to documentation. Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/reference/yaml-template.md (1)
110-126
: Alphabetical order nit-pick for the PHP tool entriesThe new PHP tool entries were added as
phpmd phpcs
phpcs
should come beforephpmd
to keep the list in (case-insensitive) alphabetical order, matching the rest of the template.- phpmd: - enabled: true - phpcs: - enabled: true + phpcs: + enabled: true + phpmd: + enabled: truedocs/tools/flake8.md (1)
24-31
: Format CLI options as code for consistency & readabilityThe option flags
--select
and--extend-ignore
render as plain text.
Surrounding them with back-ticks matches the rest of our docs style and lets them render as code.-- Select / ignore rule filtering (--select, --extend-ignore) +- Select / ignore rule filtering (`--select`, `--extend-ignore`)docs/reference/configuration.md (2)
2853-2891
: Minor wording / breadcrumb inconsistencyMost tool sections use the pattern “Review > Tools > Tool-Name > Enable” for Location.
Here it reads “Review > Tools > Enable Flake8”, dropping the intermediate tool name segment.
Consider aligning it for search consistency:- <td>Review > Tools > Enable Flake8</td> + <td>Review > Tools > Flake8 > Enable</td>Same applies to Default row directly above ‑ no change needed.
3715-3794
: Section ordering breaks PMD’s flowThe new PHPMD and PHPCS blocks were inserted between the Enable PMD subsection and PMD’s Config File subsection.
This splits PMD’s documentation in two and can confuse readers.Recommend moving the PHPMD / PHPCS blocks below the entire PMD section (after the PMD Config File table) or giving them their own top-level heading outside of the PMD section.
No diff supplied because the move spans large non-contiguous regions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/reference/configuration.md
(2 hunks)docs/reference/yaml-template.md
(2 hunks)docs/tools/flake8.md
(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
docs/reference/yaml-template.md (1)
Learnt from: alexcoderabbitai
PR: coderabbitai/coderabbit-docs#0
File: :0-0
Timestamp: 2025-06-02T14:07:49.512Z
Learning: For files in docs/tools/*.md directory: Do not recommend installation instructions or usage setup steps. All tools documented in this directory are pre-installed in CodeRabbit's default environment and require no installation steps from users. Documentation should focus on tool capabilities and features only.
docs/tools/flake8.md (1)
Learnt from: alexcoderabbitai
PR: coderabbitai/coderabbit-docs#0
File: :0-0
Timestamp: 2025-06-02T14:07:49.512Z
Learning: For files in docs/tools/*.md directory: Do not recommend installation instructions or usage setup steps. All tools documented in this directory are pre-installed in CodeRabbit's default environment and require no installation steps from users. Documentation should focus on tool capabilities and features only.
docs/reference/configuration.md (1)
Learnt from: alexcoderabbitai
PR: coderabbitai/coderabbit-docs#0
File: :0-0
Timestamp: 2025-06-02T14:07:49.512Z
Learning: For files in docs/tools/*.md directory: Do not recommend installation instructions or usage setup steps. All tools documented in this directory are pre-installed in CodeRabbit's default environment and require no installation steps from users. Documentation should focus on tool capabilities and features only.
🔇 Additional comments (1)
docs/tools/flake8.md (1)
1-37
: Good: no installation instructions – complies with docs/tools guideline
@hardikkgupta - i noticed this in one of the nitpick comments above. I think this is important to fix: "The new PHPMD and PHPCS blocks were inserted between the Enable PMD subsection and PMD’s Config File subsection. Recommend moving the PHPMD / PHPCS blocks below the entire PMD section (after the PMD Config File table) or giving them their own top-level heading outside of the PMD section." |
@hardikkgupta - this seems important to fix too: "Format CLI options as code for consistency & readability The option flags --select and --extend-ignore render as plain text. |
Add Flake8, PHPMD & PHPCS to template / reference
Add Flake8 to tools folder as well
Fixes #428