Skip to content

closes #108: cache crash #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2020
Merged

closes #108: cache crash #113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75bb9d8
avoid using cache
ShMcK Mar 1, 2020
543a51c
turn off cache on tutorials due to cache error
ShMcK Mar 1, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
turn off cache on tutorials due to cache error
  • Loading branch information
@ShMcK
ShMcK committed Mar 1, 2020
commit 543a51c2d0892ea9fbd81003fea3236b913ec306
2 changes: 1 addition & 1 deletion web-app/src/containers/New/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ interface TutorialsData {

const NewPageContainer = (props: ContainerProps) => {
const { data, loading, error } = useQuery<TutorialsData>(queryTutorials, {
fetchPolicy: 'network-only',
fetchPolicy: 'no-cache',
})

if (error) {
Expand Down
2 changes: 1 addition & 1 deletion web-app/src/containers/Overview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const Overview = (props: PageProps) => {
throw new Error('Tutorial not found in summary page')
}
const { loading, error, data } = useQuery<TutorialData, TutorialDataVariables>(queryTutorial, {
fetchPolicy: 'network-only', // to ensure latest
fetchPolicy: 'no-cache', // to ensure latest
variables: {
tutorialId: tutorial.id,
// version: tutorial.version.version, // TODO: re-enable latest
Expand Down
1 change: 1 addition & 0 deletions web-app/src/services/apollo/queries/tutorials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default gql`
description
}
version {
id
publishedAt
publishedBy {
id
Expand Down
2 changes: 1 addition & 1 deletion web-app/src/services/state/machine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export const createMachine = (options: any) => {
},
Completed: {
id: 'completed-tutorial',
onEntry: ['userTutorialComplete'],
onEntry: ['userTutorialComplete'], // unusued
on: {
SELECT_TUTORIAL: {
target: '#select-new-tutorial',
Expand Down