Skip to content

Feature/solution actions #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 29, 2019
Merged

Feature/solution actions #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9660fd
add editor solution actions
ShMcK Sep 28, 2019
3a172c5
setup load solution from client to server
ShMcK Sep 28, 2019
139eafb
add ui error boundary
ShMcK Sep 29, 2019
14fa26e
handle error when storage changed
ShMcK Sep 29, 2019
3e3a38d
run test following solution load
ShMcK Sep 29, 2019
6bf73c9
hide loadSolution on load
ShMcK Sep 29, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run test following solution load
  • Loading branch information
@ShMcK
ShMcK committed Sep 29, 2019
commit 3e3a38d3ac8b08841459b40919542a1872a1fdda
2 changes: 1 addition & 1 deletion src/actions/solutionActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import setupActions from './setupActions'

const solutionActions = async (workspaceRoot: vscode.WorkspaceFolder, stepActions: G.StepActions): Promise<void> => {
await git.clear()
setupActions(workspaceRoot, stepActions)
return setupActions(workspaceRoot, stepActions)
}

export default solutionActions
4 changes: 3 additions & 1 deletion src/channel/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ class Channel implements Channel {
return
// load solution step actions (git commits, commands, open files)
case 'SOLUTION_ACTIONS':
solutionActions(this.workspaceRoot, action.payload)
await solutionActions(this.workspaceRoot, action.payload)
// run test following solution to update position
vscode.commands.executeCommand('coderoad.run_test', action.payload)
return

default:
Expand Down