Skip to content

test fails with doctype #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2021
Merged

test fails with doctype #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test fails with doctype 
This might have missed it in hindsight, but the test fails as someone follows the tutorials.

Changing it from `<!doctype html>` to `<!DOCTYPE html>` solves the problem
  • Loading branch information
@Saif-Shines
Saif-Shines authored Jun 17, 2021
commit 2cc14f9df7f2e110f2253d1aa6e6d626779f7383
2 changes: 1 addition & 1 deletion docs/docs/create-a-practice-tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ describe('index.html', () => {
})

it('should have a DOCTYPE', () => {
assert(/<!doctype html>/i.test(indexFile))
assert(/<!DOCTYPE html>/i.test(indexFile))
})
})
```
Expand Down