Skip to content

Persist scheme-less account login hosts as HTTPS#5727

Draft
50sotero wants to merge 1 commit into
databricks:mainfrom
50sotero:fix/issue-1403-auth-login-host-scheme
Draft

Persist scheme-less account login hosts as HTTPS#5727
50sotero wants to merge 1 commit into
databricks:mainfrom
50sotero:fix/issue-1403-auth-login-host-scheme

Conversation

@50sotero

Copy link
Copy Markdown

Changes

  • normalize classic account-console login hosts without a scheme before saving the profile
  • keep arbitrary workspace host inputs unchanged
  • update auth token ambiguity coverage to expect the normalized account host

Fixes #1403

Tests

  • go test ./cmd/auth -run TestSetHost -count=1
  • go test ./cmd/auth -count=1
Scheme-less account-console hosts are valid user input during login, but persisting them without https:// leaves later account commands unable to build a valid account configuration. Normalize only classic accounts.* login hosts after existing slash trimming so arbitrary workspace hosts and test placeholders keep their current spelling.

Constraint: User input may omit the URL scheme for accounts.cloud.databricks.com.
Rejected: Canonicalize every login host | broader behavior change for workspace aliases and existing placeholder inputs.
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Keep login host normalization conservative unless profile matching and saved config compatibility are tested together.
Tested: go test ./cmd/auth -run TestSetHost -count=1
Tested: go test ./cmd/auth -count=1
Related: databricks#1403
@github-actions

Copy link
Copy Markdown
Contributor

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 5727
  • Commit SHA: c64b123cc11f27975b2abe00665ee36dbd0c5b12

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant