Fix cooldown being incorrectly applied to security updates #14050
+50
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Security updates were incorrectly filtering versions due to cooldown, causing "Dependabot cannot update to the required version" errors. Per documentation, cooldown should only apply to version updates, not security updates.
Anything you want to highlight for special attention from reviewers?
Two
update_checker_formethods unconditionally passedjob.cooldown:updater/lib/dependabot/updater/operations/update_all_versions.rbupdater/lib/dependabot/updater/group_update_creation.rbFix passes
nilwhenjob.security_updates_only?is true:The security-specific operations (
CreateSecurityUpdatePullRequest,RefreshSecurityUpdatePullRequest) already omit cooldown entirely—this fix aligns the shared code paths.How will you know you've accomplished your goal?
Added tests in
update_all_versions_spec.rbverifying:Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.launchpad.net/usr/bin/add-apt-repository add-apt-repository -y ppa:git-core/ppa grep rity.crt -q la/emSign_Root_CA_-_G1.crt e u3_amd64.deb(dns block)ports.ubuntu.com/usr/lib/apt/methods/http /usr/lib/apt/methods/http(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
cooldown#13979💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.