Skip to content

gha: update actions, and update to go1.21, go1.22#16

Merged
milosgajdos merged 6 commits into
distribution:mainfrom
thaJeztah:update_gha
Jul 18, 2024
Merged

gha: update actions, and update to go1.21, go1.22#16
milosgajdos merged 6 commits into
distribution:mainfrom
thaJeztah:update_gha

Conversation

@thaJeztah

Copy link
Copy Markdown
Member
  • gha: update actions/checkout@v4
  • gha: update actions/setup-go@v5
  • gha: update golangci/golangci-lint-action@v6
  • gha: update codecov/codecov-action@v4
  • gha: update golangci-lint to v1.59
  • gha: update to go1.21.x, go1.22.x
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah self-assigned this Jul 15, 2024
    Error: fuzz_test.go:11:14: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
        f.Fuzz(func(t *testing.T, data string) {
                    ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov

codecov Bot commented Jul 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (ff14faf) to head (343e590).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   83.71%   84.21%   +0.49%     
==========================================
  Files           5        5              
  Lines         393      304      -89     
==========================================
- Hits          329      256      -73     
+ Misses         54       38      -16     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thaJeztah thaJeztah requested review from Jamstah and milosgajdos July 15, 2024 11:58
@thaJeztah thaJeztah changed the title aha: update actions, and update to go1.21, go1.22 Jul 15, 2024

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milosgajdos

Copy link
Copy Markdown
Member

@thaJeztah do you want to squash?

@thaJeztah

Copy link
Copy Markdown
Member Author

It's probably fine to keep them separate; each of them is for a specific dependency, so they don't really depend on each other.

@thaJeztah

Copy link
Copy Markdown
Member Author

(if that's good to you that is)

@milosgajdos milosgajdos merged commit 8c942b0 into distribution:main Jul 18, 2024
@thaJeztah thaJeztah deleted the update_gha branch July 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants