Skip to content

Fix selenium test flakiness #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carltongibson merged 1 commit into from
Dec 1, 2025
Merged

Fix selenium test flakiness #2202

carltongibson merged 1 commit into from
Dec 1, 2025

Conversation

@vladimirnani
Copy link
Contributor

@vladimirnani vladimirnani commented Nov 30, 2025

Currently:

  1. Django renders the <strong>Total messages:</strong> <span id="messageCount">0</span>
  2. Test test_real_time_delete_message creates a new message and hits page refresh
  3. Test refreshes the page but doesnt wait for message to be handled, so renderState is not able to update the counter
  4. Test finds the existing count element and asserts that count 0 is not expected 1.

PR changes:

  • explicitly wait on window.messageHandled in js to be sure that renderState has finished.

Removes flakiness on fast machine.
@vladimirnani
Selenium waits on message to be handled
7b3aef8 
Removes flakiness on fast machine
@vladimirnani vladimirnani changed the title Selenium waits on message to be handled Dec 1, 2025
carltongibson
carltongibson approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks sensible. Thanks!
@carltongibson carltongibson merged commit 0a4f2cb into django:main Dec 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vladimirnani @carltongibson