Skip to content

Error handling enhancement - #258

Open
minhhung2556 wants to merge 4 commits into
dnfield:mainfrom
minhhung2556:feature/error-handling-enhancement
Open

Error handling enhancement#258
minhhung2556 wants to merge 4 commits into
dnfield:mainfrom
minhhung2556:feature/error-handling-enhancement

Conversation

@minhhung2556

Copy link
Copy Markdown

Title

Error handling when loading and parsing SVG files.

Purpose

This PR is support for another PR to flutter_svg, which will fix some related issues:
#219
dnfield/flutter_svg#1100
dnfield/flutter_svg#1085
dnfield/flutter_svg#1080
dnfield/flutter_svg#1044
dnfield/flutter_svg#996
dnfield/flutter_svg#1007

Changes Made

  • catch error cases and return results to SVGPicture.

Testing

  • Already tested by example and unit test in flutter_svg

Impact

This change should not affect other parts of the library.

@minhhung2556 minhhung2556 changed the title Feature/error handling enhancement Oct 4, 2024
@zanderso

zanderso commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Hi there, The Flutter team is now maintaining these packages in the flutter/packages repository at packages/vector_graphics and packages/vector_graphics_compiler. We'd appreciate it if you could direct this PR to those locations instead. Thanks!

minhhung2556 added a commit to minhhung2556/flutter-packages that referenced this pull request Nov 4, 2024
minhhung2556 added a commit to minhhung2556/flutter-packages that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants