Skip to content

Conversation

@geoHeil
Copy link
Contributor

@geoHeil geoHeil commented Jan 20, 2026

resolves: #2584 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

DCO Check Passed

Thanks @geoHeil, all your commits are properly signed off. 🎉

…#2584)

Add explicit control for using RapidOCR's bundled models instead of
artifacts_path. This addresses the issue where users couldn't use
RapidOCR's pre-packaged models when artifacts_path was set globally.

Changes:
- Add use_bundled_models flag to RapidOcrOptions (default: False)
- When True: Ignores artifacts_path and uses RapidOCR's bundled models
- When False: Follows Docling's standard behavior (uses artifacts_path)
- Explicitly set model paths always take precedence

This maintains Docling's design philosophy where artifacts_path controls
model sources by default, while providing an explicit opt-in for users
who want to use RapidOCR's pre-installed models.

Fixes docling-project#2584

Signed-off-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>
@mergify
Copy link

mergify bot commented Jan 20, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling/models/stages/ocr/rapid_ocr_model.py 50.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant