[build] enable TSA reporting on more steps #10240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/sdlanalysis/tsasupport Context: #10239 PR #10239 is a nice step, in fixing our TSA reporting for Policheck. However, we need to enable it for our entire pipeline. There are other security scanning tools that need this setting.
|
Testing a full run here: |
Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/sdlanalysis/credscan Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2514776 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2514777 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2514778 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2514779 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2514780
Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/sdlanalysis/binskim Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2514823 This opened 309 work items, so not going to link them all here.
Fixes:
##[error]TsaConfigFormatException: Unable to read the TsaOptions config file. Please check the format of the file: /mnt/vss/_work/1/s\.gdn\tsaoptions-v2.json
##[error]GuardianFileNotFoundException: Unable to find required file at: /mnt/vss/_work/1/s\.gdn\tsaoptions-v2.json
Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-mohanb/security-integration/guardian-wiki/sdl-azdo-extension/binskim-build-task Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/sdlanalysis/binskim
This reverts commit 34e4061.
|
Testing another full run: |
REVERT ME later
This reverts commit 1df12ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/sdlanalysis/tsasupport
Context: #10239
PR #10239 is a nice step, in fixing our TSA reporting for Policheck.
However, we need to enable it for our entire pipeline. There are other security scanning tools that need this setting.