-
Notifications
You must be signed in to change notification settings - Fork 10.4k
feat(HTTP.SYS): on-demand TLS client hello retrieval #62209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DeagleGross
merged 8 commits into
dotnet:main
from
DeagleGross:dmkorolev/httpsys-ondemand-tlsclienthello
Jun 7, 2025
Merged
feat(HTTP.SYS): on-demand TLS client hello retrieval #62209
DeagleGross
merged 8 commits into
dotnet:main
from
DeagleGross:dmkorolev/httpsys-ondemand-tlsclienthello
Jun 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
approved these changes
Jun 2, 2025
src/Servers/HttpSys/samples/TlsFeaturesObserve/TlsFeaturesObserve.csproj
Show resolved
Hide resolved
src/Servers/HttpSys/src/RequestProcessing/RequestContext.FeatureCollection.cs
Show resolved
Hide resolved
tdykstra
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just A few nits.
BrennanConroy
approved these changes
Jun 6, 2025
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/15546470366 |
@DeagleGross backporting to "release/8.0" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: drop callback / implement on-demand tls client hello access
Using index info to reconstruct a base tree...
M src/Servers/HttpSys/samples/TlsFeaturesObserve/Program.cs
M src/Servers/HttpSys/src/HttpSysListener.cs
M src/Servers/HttpSys/src/HttpSysOptions.cs
M src/Servers/HttpSys/src/PublicAPI.Unshipped.txt
M src/Servers/HttpSys/src/RequestProcessing/Request.cs
M src/Servers/HttpSys/src/RequestProcessing/RequestContext.FeatureCollection.cs
M src/Servers/HttpSys/src/RequestProcessing/RequestContext.cs
M src/Servers/HttpSys/src/RequestProcessing/TlsListener.cs
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): src/Servers/HttpSys/src/RequestProcessing/TlsListener.cs deleted in drop callback / implement on-demand tls client hello access and modified in HEAD. Version HEAD of src/Servers/HttpSys/src/RequestProcessing/TlsListener.cs left in tree.
Removing src/Servers/HttpSys/src/RequestProcessing/TlsListener.Log.cs
Auto-merging src/Servers/HttpSys/src/RequestProcessing/RequestContext.cs
CONFLICT (content): Merge conflict in src/Servers/HttpSys/src/RequestProcessing/RequestContext.cs
Auto-merging src/Servers/HttpSys/src/RequestProcessing/RequestContext.FeatureCollection.cs
Auto-merging src/Servers/HttpSys/src/RequestProcessing/Request.cs
CONFLICT (content): Merge conflict in src/Servers/HttpSys/src/RequestProcessing/Request.cs
Auto-merging src/Servers/HttpSys/src/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/Servers/HttpSys/src/PublicAPI.Unshipped.txt
Auto-merging src/Servers/HttpSys/src/HttpSysOptions.cs
CONFLICT (content): Merge conflict in src/Servers/HttpSys/src/HttpSysOptions.cs
Auto-merging src/Servers/HttpSys/src/HttpSysListener.cs
CONFLICT (content): Merge conflict in src/Servers/HttpSys/src/HttpSysListener.cs
Removing src/Servers/HttpSys/samples/TlsFeaturesObserve/Startup.cs
Auto-merging src/Servers/HttpSys/samples/TlsFeaturesObserve/Program.cs
CONFLICT (content): Merge conflict in src/Servers/HttpSys/samples/TlsFeaturesObserve/Program.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 drop callback / implement on-demand tls client hello access
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
DeagleGross
added a commit
to DeagleGross/aspnetcore
that referenced
this pull request
Jun 9, 2025
10 tasks
joperezr
pushed a commit
that referenced
this pull request
Jun 11, 2025
* feat(HTTP.SYS): on-demand TLS client hello retrieval (#62209) * fix cherry-pick * setup sample * provide example * fix build error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
feature-httpsys
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP.SYS only on-demand TLS client hello
As discussed in api proposal we are doing 2 things here:
HttpSysOptions.TlsClientHelloBytesCallback
IHttpSysRequestPropertiesFeature
:IHttpSysRequestPropertiesFeature.TryGetTlsClientHello
.TlsFeaturesObserve.Program
sample shows the usage of that feature and this API in particular:Implements #61625