Pin vsce version used in release script#5704
Merged
captainsafia merged 1 commit intomainfrom Nov 7, 2021
Merged
Conversation
ryanbrandenburg
approved these changes
Nov 5, 2021
Contributor
ryanbrandenburg
left a comment
ryanbrandenburg
left a comment
There was a problem hiding this comment.
Sounds good to me if it fixes it!
Contributor
|
I suspect the specific behavior pinning protects us from is microsoft/vscode-vsce#628. Another project ran into a similar problem. If the License file IS the issue would it be possible for us to include one in future releases? |
Contributor
Author
Yep. I suppose we can use the MIT license as is done repo-wide. |
NTaylorMullen
pushed a commit
that referenced
this pull request
Nov 12, 2021
NTaylorMullen
pushed a commit
that referenced
this pull request
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to resolve recent issues with this build step by pinning the vsce version used to a known value.