Skip to content

Add support for classes in JRT - #56

Open
helospark wants to merge 2 commits into
ecd-plugin:masterfrom
helospark:github-issue-55-jrt-issue-with-java-9
Open

helospark wants to merge 2 commits into
ecd-plugin:masterfrom
helospark:github-issue-55-jrt-issue-with-java-9

Conversation

@helospark

@helospark helospark commented Nov 16, 2018 •

Copy link
Copy Markdown

What

Why

  • Java 9 no longer contains it's class files in JAR files like previous versions, it now uses a modules file. https://openjdk.java.net/jeps/220
  • So trying to load a JDK class from jar it will fail to decompile. Most JDK classes have source in the JDK src.zip, so it won't affect those

How

Notes

  • JRTUtil was introduced in Eclipse Oxygen, so I had to raise the version.
    However this should not limit the installability of the plugin, because the jdt versions are not fixed in MANIFEST file. I have added an additional catch, so earlier versions of Eclipse will not fail with ClassDefNotFound exception.
    When the baseline of the plugin is incremented, that try-catch can be removed
@RobertZenz
RobertZenz self-requested a review November 18, 2018 18:54
@RobertZenz RobertZenz self-assigned this Nov 18, 2018
@RobertZenz RobertZenz added this to the 3.2 milestone Nov 18, 2018
@pbi-qfs

pbi-qfs commented Nov 19, 2018

Copy link
Copy Markdown
Collaborator

Sounds great, thank you!

@RobertZenz

Copy link
Copy Markdown
Collaborator

I'll be unable to review this in depth for various reasons within the next time. Can somebody else please test this?

@RobertZenz
RobertZenz removed their request for review December 14, 2018 08:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants