Skip to content

fix: disable inline comments highlighting in .editorconfig files#473

Merged
SunsetTechuila merged 1 commit intoeditorconfig:mainfrom
DecimalTurn:comment
Mar 25, 2026
Merged

fix: disable inline comments highlighting in .editorconfig files#473
SunsetTechuila merged 1 commit intoeditorconfig:mainfrom
DecimalTurn:comment

Conversation

@DecimalTurn
Copy link
Copy Markdown
Contributor

@DecimalTurn DecimalTurn commented Mar 25, 2026

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run build).
  • Run npm run lint w/o errors.

Currently, the syntax highlighting makes you think that comments at the end of a line are valid while they are not.

image

Per the docs:

Comments should go on their own lines.

These changes also align with the grammar in the atom extension's grammar
@SunsetTechuila
Copy link
Copy Markdown
Member

SunsetTechuila commented Mar 25, 2026

Thank you
@SunsetTechuila SunsetTechuila changed the title fix: update comment patterns to match from the start of the line Mar 25, 2026
@SunsetTechuila SunsetTechuila merged commit 2d0fbbb into editorconfig:main Mar 25, 2026
3 checks passed
@DecimalTurn DecimalTurn deleted the comment branch March 25, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@DecimalTurn @SunsetTechuila