Fix max_keepalive_connections #1000
Merged
+32
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazewicz
commented
Mar 26, 2025
blazewicz
commented
Mar 26, 2025
blazewicz
force-pushed
the
blazewicz/fix-max-keepalive-connections
branch
2 times, most recently
from
0aa2ee1 to
6414fd8
Compare
methane
approved these changes
Sep 3, 2025
zanieb
approved these changes
Sep 22, 2025
Contributor
zanieb
left a comment
zanieb
left a comment
There was a problem hiding this comment.
This does seem like a fairly straightforward oversight in the implementation.
This commit fixes a bug in both sync and async connection pools where idle connections were dropped from the pool even when max_keepalive_connections limit has not been reached. This happened because the check compared this number to the total number of connections, not only the idle ones.
blazewicz
force-pushed
the
blazewicz/fix-max-keepalive-connections
branch
from
6414fd8 to
7fb2052
Compare
Contributor
|
Ah yeah apologies... this is a nice simple fix, and worth getting in. |
|
Will this be released soon in a formal release? Perhaps a 1.0.10? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes a bug in both sync and async connection pools where idle connections were dropped from the pool even when max_keepalive_connections limit has not been reached. This happened because the check compared this setting's value to the total number of connections, not only of the idle ones.
Checklist