fix: float arguments in host function parameters#39
Merged
Conversation
Member
|
@regisb sorry for the delay on this, looks like a test is failing due to a linter issue. If you don't mind, would you take a look & patch this up? |
regisb
force-pushed
the
regisb/fix-float-host-fn-args
branch
from
15be869 to
d314c48
Compare
There was a small typo in _convert_value which logged an error whenever
a host function with float argument was called:
Exception ignored from cffi callback <function handle_args at 0x7fee3735b480>:
Traceback (most recent call last):
File ".../extism/extism.py", line 908, in handle_args
inp.append(_convert_value(inputs[i]))
File ".../extism/extism.py", line 648, in _convert_value
elif x.y == 3:
AttributeError: cdata 'ExtismVal' has no field 'y'
Contributor
Author
|
Sure thing, my bad! I should have run the test suite locally. |
regisb
force-pushed
the
regisb/fix-float-host-fn-args
branch
from
d314c48 to
3efe901
Compare
nilslice
approved these changes
Feb 23, 2026
Member
|
Thank you! Will cut a release later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a small typo in
_convert_valuewhich logged an error whenever a host function with float argument was called: