fix(docsite): use Link trigger in HoverCard "Link Preview" example (#2728)#3279
fix(docsite): use Link trigger in HoverCard "Link Preview" example (#2728)#3279mohitWeb-lab wants to merge 1 commit into
Conversation
…acebook#2728) The trigger was plain text, giving no semantic link affordance. Replace with a Link component (hasUnderline) so the example demonstrates the actual link preview pattern and the trigger is visually discoverable.
mohitWeb-lab
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
@mohitWeb-lab is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @mohitWeb-lab! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
meta-cla
Bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Summary
The "Link Preview" example on the HoverCard docsite page had no interactive trigger — the HoverCard child was a plain text string, leaving nothing visually distinct to hover over.
Cause
The HoverCardInteractiveContent example passed "Getting Started Guide" as a plain text child to HoverCard. While HoverCard does wrap text-only children in a hoverable , this gave no semantic link affordance — there was no underline, no cursor change, and nothing to signal to the user that the text was interactive. For a "Link Preview" pattern specifically, the trigger should be an actual link.
Fix
Replaced the plain text child with Getting Started Guide. hasUnderline ensures the underline is always visible (not just on hover), making the trigger immediately discoverable. Updated componentsUsed in the doc to include 'Link' and propagated the change to all generated registry files.
Closes #2728