docs(dense): restore bestPractices parity for useLayer#3300
Open
josephfarina wants to merge 1 commit into
Open
docs(dense): restore bestPractices parity for useLayer#3300josephfarina wants to merge 1 commit into
josephfarina wants to merge 1 commit into
Conversation
Found during Night Watch doc review. The docsDense overlay for useLayer had 3 bestPractices while the English docs had 4; the guidance about the Popover API top layer (inline render, no portal, as: span for inline contexts) was missing, so dense CLI output silently dropped it. Added a compressed version at the matching position with guidance: true, keeping 1:1 count and order parity.
josephfarina
requested review from
cixzhang,
ejhammond,
imdreamrunner,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
docsDenseoverlay foruseLayerlisted 3 bestPractices while theEnglish
docslisted 4. The missing guidance was the third Englishbullet about the Popover API top layer (render inline, no portal, so it
inherits the trigger theme cascade and focus order; use
as: "span"forinline contexts). Because the loader falls back per-field, dense CLI
output silently dropped that guidance.
Added a compressed version at the matching position with
guidance: true,restoring 1:1 count and order parity. No other bullets changed.
Checklist
pnpm --filter @astryxdesign/core typecheck:docspassesnpx tsc --project packages/cli/tsconfig.template-docs.json --noEmitpassesnode .github/scripts/api-cli-parity-test.mjs --no-baselinepasses (307/307)astryx component useLayer --lang denseshows all 4 bestPractices, correct Do/Don't flagsNight Watch — Doc Reviewer