Remove dangling pyrefly_wasm/rust-toolchain symlink#3995
Open
kinto0 wants to merge 1 commit into
Open
Conversation
Summary: The symlink pyrefly_wasm/rust-toolchain pointed at ../pyrefly/rust-toolchain, whose target was deleted as redundant in D105227815, leaving the symlink dangling. Swatinem/rust-cache globs for rust-toolchain files and crashes with ENOENT when it follows the broken link, breaking the CodSpeed (and eventually all rust-cache) CI jobs on the GitHub mirror. rustup already resolves the toolchain by walking up to the repo-root rust-toolchain.toml, so the symlink is redundant; removing it fixes the cache step with no loss of toolchain pinning for the wasm build. Differential Revision: D110230704
Contributor
|
@kinto0 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110230704. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The symlink pyrefly_wasm/rust-toolchain pointed at ../pyrefly/rust-toolchain, whose target was deleted as redundant in D105227815, leaving the symlink dangling. Swatinem/rust-cache globs for rust-toolchain files and crashes with ENOENT when it follows the broken link, breaking the CodSpeed (and eventually all rust-cache) CI jobs on the GitHub mirror. rustup already resolves the toolchain by walking up to the repo-root rust-toolchain.toml, so the symlink is redundant; removing it fixes the cache step with no loss of toolchain pinning for the wasm build.
Differential Revision: D110230704