Skip to content

FeedSim build scripts improvements - #322

Open
lukalt wants to merge 12 commits into
facebookresearch:v2-betafrom
lukalt:v2-beta-fixes-lalt
Open

lukalt wants to merge 12 commits into
facebookresearch:v2-betafrom
lukalt:v2-beta-fixes-lalt

Conversation

@lukalt

@lukalt lukalt commented Nov 25, 2025 •

Copy link
Copy Markdown
Contributor

The suggested changes improve the speed and integrity of the FeedSim installation on aarch64 CentOS:

  • Use precompiled cmake instead of building it on the fly, which takes several minutes
  • Fix all other dependencies being installed to fast_float folder
  • Validate checksum for third-party dependencies that are downloaded during installation
  • Correctly specify CMake dependencies for mvfst and fbthrift. Otherwise parallel builds fail
  • Build feedsim in parallel, gives great speedup when building ICacheBuster
  • Build boost in parallel

Open questions:

  • fast_float is installed but never used by FeedSim or its dependencies. Can it safely be removed?
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2025
@excelle08

Copy link
Copy Markdown
Contributor

I remember fast_float is a dependency of fbthrift so we can't remove it - unless you've validated that it's not used by fbthrift when building on aarch64

@meta-codesync

meta-codesync Bot commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

@ahmadelyoussef has imported this pull request. If you are a Meta employee, you can view this in D87904059.

@lukalt

lukalt commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

I remember fast_float is a dependency of fbthrift so we can't remove it - unless you've validated that it's not used by fbthrift when building on aarch64

Thanks. Just confirmed that fast_float is indeed required by folly (see https://github.com/facebook/fbthrift/blob/be70399cc5f6371a8b9c74a6647d280f20d2e1ae/build/fbcode_builder/manifests/folly#L23).

@lukalt

lukalt commented Nov 27, 2025

Copy link
Copy Markdown
Contributor Author

@excelle08 @ahmadelyoussef I wanted to also apply these changes to the Ubuntu install script and realized that all the install scripts are mostly redundant so I merged them into a single install script for both architectures and both Linux distributions

meta-codesync Bot pushed a commit that referenced this pull request May 5, 2026
Summary:
Pull Request resolved: #613

The suggested changes improve the speed and integrity of the FeedSim installation on aarch64 CentOS:
- Use precompiled cmake instead of building it on the fly, which takes several minutes
- Fix all other dependencies being installed to `fast_float` folder
- Validate checksum for third-party dependencies that are downloaded during installation
- Correctly specify CMake dependencies for mvfst and fbthrift. Otherwise parallel builds fail
- Build feedsim in parallel, gives great speedup when building ICacheBuster
- Build boost in parallel

Open questions:
- `fast_float` is installed but never used by FeedSim or its dependencies. Can it safely be removed?

Pull Request resolved: #322

Reviewed By: excelle08

Differential Revision: D87904059

Pulled By: ahmadelyoussef

fbshipit-source-id: 7117a4a42f0024b6671882e5415d47b31610d270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

2 participants