fix: ColumnGroup doesn't accept HtmlString as label (#19152)
#19157
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19152
Problem
When using an
HtmlStringas aColumnGrouplabel (which is allowed by the type signature), PHP throws an error:This happens because the code was trying to use the
HtmlStringobject directly as an array key, but PHP only allows strings or integers as array keys.Solution
I used
e()instead of a(string)cast to match the existing pattern in the codebase. InHasColumnManager::mapTableColumnGroupToArray(), the same conversion is already done withe():Testing
Added a test case that reproduces the bug and verifies the fix. Without the fix, the test fails with the exact error from the issue. With the fix, all tests pass.