Skip to content

framework: npm timeout in big projects breaks deploy #8689

@tharvik

Description

@tharvik

when deploy w/ a framework, npm list --json is called a few times via findDependency. in some larger project, the relatively low timeout (10s) will trigger and make the function throw when parsing it as JSON.
note: the result.stdout check is never taken as it is a Buffer, not a string

I've got a small patch to utils.envOverride("NPM_COMMAND_TIMEOUT_MILLIES", …) in constants.ts but I'd even argue that removing the whole timeout check is a saner fix (w/ this Halting issue of Turing complet languages ya know). WDYT?

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions