-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Better message for api enablement failures #6130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
55fbe26
Better message for api enablement failures
hsubox76 72a405a
Merge branch 'master' into ch-api-enable
hsubox76 84c6149
missed a spot
hsubox76 af7319a
Merge branch 'master' into ch-api-enable
hsubox76 5327c22
Add changelog entry and fix exec call
hsubox76 8f1052b
Merge branch 'master' into ch-api-enable
hsubox76 ddda192
Merge branch 'ch-api-enable' of https://github.com/firebase/firebase-…
hsubox76 3f4a681
remove extra line
hsubox76 692280c
Revert package.json
hsubox76 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| - Fixed bug where `functions:secrets:set` didn't remove stale versions of a secret. (#6080) | ||
| - Fixed bug where `firebase deploy --only firestore:named-db` didn't update rules. (#6129) | ||
| - Fixed issue where Flutter Web is not detected as a web framework. (#6085) | ||
| - Add better messages for API permissions failures that direct the user to the URL to enable the API. (#6130) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wont this fail if permissionsError.length <2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but if it fails that means my regex failed and I don't have a capturing group with the string of the API name, so I can't go forward with constructing this message anyway. It will fall back to throwing the original error which should be the most useful thing we have.