Skip to content

Fix hosting rewrite deployment bug for skipped functions #6658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colerogers merged 3 commits into from
Mar 15, 2024
Merged

Fix hosting rewrite deployment bug for skipped functions #6658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d6cb27
copy the service ID
colerogers Jan 2, 2024
a9fbf28
changelog
colerogers Jan 2, 2024
9a86397
Merge branch 'master' into colerogers-fix-skip-hosting-rewrites
colerogers Mar 15, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix hosting rewrite deployment bug for skipped functions (#6658).
3 changes: 3 additions & 0 deletions src/deploy/functions/prepare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ export function inferDetailsFromExisting(
continue;
}

// Copy the service id over to the new endpoint.
wantE.runServiceId = haveE.runServiceId;

// By default, preserve existing environment variables.
// Only overwrite environment variables when there are user specified environment variables.
if (!usedDotenv) {
Expand Down