Skip to content

Fixed an issue where firestore:delete would not use the emulator when it should#6772

Merged
joehan merged 4 commits intomasterfrom
jh-firestore-right
Feb 14, 2024
Merged

Fixed an issue where firestore:delete would not use the emulator when it should#6772
joehan merged 4 commits intomasterfrom
jh-firestore-right

Conversation

@joehan
Copy link
Copy Markdown
Member

@joehan joehan commented Feb 13, 2024

Description

Fixed an issue where firestore:delete would not use the emulator when FIRESTORE_EMULATOR_HOST was set
Fixes #6537

@joehan joehan requested a review from rwhogg February 13, 2024 23:26
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 13, 2024

Codecov Report

❌ Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.31%. Comparing base (b513b0d) to head (9cd210f).
⚠️ Report is 1232 commits behind head on master.

Files with missing lines Patch % Lines
src/gcp/firestore.ts 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6772      +/-   ##
==========================================
- Coverage   54.32%   54.31%   -0.01%     
==========================================
  Files         350      350              
  Lines       24288    24296       +8     
  Branches     5021     5028       +7     
==========================================
+ Hits        13194    13196       +2     
- Misses       9888     9894       +6     
  Partials     1206     1206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@joehan joehan requested a review from rwhogg February 14, 2024 16:10
@joehan joehan merged commit 9cf6921 into master Feb 14, 2024
@joehan joehan deleted the jh-firestore-right branch February 14, 2024 18:58
@Pickachu
Copy link
Copy Markdown

Thanks for PR team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants