Fix invalid option names in Firestore backup schedule commands#7473
Closed
TomasMorton wants to merge 2 commits intofirebase:masterfrom
TomasMorton:tm-firestore-fix-option-names
Closed
Fix invalid option names in Firestore backup schedule commands#7473TomasMorton wants to merge 2 commits intofirebase:masterfrom TomasMorton:tm-firestore-fix-option-names
TomasMorton wants to merge 2 commits intofirebase:masterfrom
TomasMorton:tm-firestore-fix-option-names
Conversation
rwhogg
approved these changes
Jul 19, 2024
joehan
approved these changes
Jul 23, 2024
joehan
reviewed
Jul 23, 2024
Member
joehan
left a comment
There was a problem hiding this comment.
Can you add a changelog entry for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some firestore commands were incorrectly using two characters in their short option name. When passing two characters on the command line, only the first is actually parsed and checked, resulting in either unknown args or mismatched args.
Scenarios Tested
Success scenarios
Failure scenarios
Sample Commands