Skip to content

fix: handle paths with spaces in getGlobalEsbuildVersion function #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leoortizz merged 7 commits into from
Sep 18, 2024
Merged

fix: handle paths with spaces in getGlobalEsbuildVersion function #7571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3583843
fix: handle paths with spaces in getGlobalEsbuildVersion function
dxdc Aug 20, 2024
0f5a06b
Merge branch 'master' into dxdc-next-patch-1
dxdc Aug 20, 2024
d9ad8de
fix failing test
dxdc Aug 20, 2024
50370bb
Merge branch 'master' into dxdc-next-patch-1
dxdc Aug 20, 2024
ca51c59
Merge branch 'master' into dxdc-next-patch-1
dxdc Sep 12, 2024
84f6549
Merge branch 'master' into dxdc-next-patch-1
chalosalvador Sep 13, 2024
0d88e9a
Merge branch 'master' into dxdc-next-patch-1
leoortizz Sep 18, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/frameworks/next/utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ describe("Next.js utils", () => {
.withArgs("npx which esbuild", { encoding: "utf8" })
.returns(mockBinaryPath + "\n");
execSyncStub
.withArgs(`${mockBinaryPath} --version`, { encoding: "utf8" })
.withArgs(`"${mockBinaryPath}" --version`, { encoding: "utf8" })
.returns(`${mockGlobalVersion}\n`);

const consoleWarnStub = sinon.stub(console, "warn");
Expand Down
2 changes: 1 addition & 1 deletion src/frameworks/next/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ export function findEsbuildPath(): string | null {
*/
export function getGlobalEsbuildVersion(binPath: string): string | null {
try {
const versionOutput = execSync(`${binPath} --version`, { encoding: "utf8" })?.trim();
const versionOutput = execSync(`"${binPath}" --version`, { encoding: "utf8" })?.trim();
if (!versionOutput) {
return null;
}
Expand Down