Skip to content

Fix TLS ready check now that we switched from node-fetch to fetch #7595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inlined merged 5 commits into from
Sep 3, 2024
Merged

Fix TLS ready check now that we switched from node-fetch to fetch #7595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f004b1
Fix TLS ready check now that we switched from node-fetch to fetch
inlined Aug 26, 2024
643be85
Changelog
inlined Aug 26, 2024
3aa8241
Actual fix
inlined Aug 26, 2024
3c64c0e
Format
inlined Aug 26, 2024
3a73dbf
Merge branch 'master' into inlined.fix-tls-check
inlined Sep 3, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Re-add a dialog to let users know TLS is being provisioned in App Hosting (#7595)
- Improve Firebase Data Connect postgres security by granting fine grained SQL privileges to the users the need it. (#7578)
- Remove `dataconnect:sql:migrate` command hard dependency on 'roles/cloudsql.admin'. (#7578)
- Add support for setting the encryption configuration of restored firestore databases (#7483)
7 changes: 5 additions & 2 deletions src/apphosting/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,11 @@ async function tlsReady(url: string): Promise<boolean> {
// At the time of this writing, the error code is ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE.
// I've chosen to use a regexp in an attempt to be forwards compatible with new versions of
// SSL.
const maybeNodeError = err as { cause: { code: string } };
if (/HANDSHAKE_FAILURE/.test(maybeNodeError?.cause?.code)) {
const maybeNodeError = err as { cause: { code: string }; code: string };
if (
/HANDSHAKE_FAILURE/.test(maybeNodeError?.cause?.code) ||
"EPROTO" === maybeNodeError?.code
) {
return false;
}
return true;
Expand Down