Skip to content

Fix regex pattern used to verify Cloud Storage bucket name#8157

Merged
joehan merged 3 commits intomasterfrom
aalej-ext-csb-name
Feb 4, 2025
Merged

Fix regex pattern used to verify Cloud Storage bucket name#8157
joehan merged 3 commits intomasterfrom
aalej-ext-csb-name

Conversation

@aalej
Copy link
Copy Markdown
Contributor

@aalej aalej commented Jan 30, 2025

Description

Fixes #8152

From what I can gather, there are currently 2 formats being used for Cloud Storage bucket names. PROJECT_ID.firebasestorage.app for the new ones, PROJECT_ID.appspot.com for the old ones

Logging the bucketResourceNameTokens of new and old projects:
New:

--- bucketResourceNameTokens
[
  'projects',
  'PROJECT_ID',
  'buckets',
  'PROJECT_ID.firebasestorage.app'
]

Old:

--- bucketResourceNameTokens
[
  'projects',
  'PROJECT_ID',
  'buckets',
  'PROJECT_ID.appspot.com'
]

Scenarios Tested

Using an old project with that has a PROJECT_ID.appspot.com Cloud Storage bucket name:

  1. Run firebase init extensions --project PROJECT_ID
  2. Run firebase ext:install firebase/delete-user-data --project=PROJECT_ID
    • Answer all prompts
    • In extensions/delete-user-data.env
...
CLOUD_STORAGE_BUCKET=PROJECT_ID.appspot.com
...
  1. Run firebase deploy
=== Deploying to 'PROJECT_ID'...

i  deploying extensions
i  extensions: ensuring required API firebaseextensions.googleapis.com is enabled...
✔  extensions: required API firebaseextensions.googleapis.com is enabled
i  extensions: ensuring required API compute.googleapis.com is enabled...
✔  extensions: required API compute.googleapis.com is enabled
The following extension instances will be configured:
        delete-user-data (firebase/delete-user-data@0.1.23)

i  extensions: By installing an extension instance onto a Firebase project, you accept the Firebase Extensions User Terms of Service: https://firebase.google.com/terms/extensions/user
✔  extensions Successfully validated configure for delete-user-data
i  extensions: Configuring delete-user-data extension instance
✔  extensions Successfully configured delete-user-data
Using Google Analytics in DEBUG mode. Emulators (+ UI) events will be shown in GA Debug View only.

✔  Deploy complete!

Using a new project with that has a PROJECT_ID.firebasestorage.app Cloud Storage bucket name:

  1. Run firebase init extensions --project PROJECT_ID
  2. Run firebase ext:install firebase/delete-user-data --project=PROJECT_ID
    • Answer all prompts
    • In extensions/delete-user-data.env
...
CLOUD_STORAGE_BUCKET=PROJECT_ID.firebasestorage.app
...
  1. Run firebase deploy
=== Deploying to 'PROJECT_ID'...

i  deploying extensions
i  extensions: ensuring required API firebaseextensions.googleapis.com is enabled...
✔  extensions: required API firebaseextensions.googleapis.com is enabled
i  extensions: ensuring required API compute.googleapis.com is enabled...
✔  extensions: required API compute.googleapis.com is enabled
The following extension instances will be created:
        delete-user-data (firebase/delete-user-data@0.1.23)

i  extensions: By installing an extension instance onto a Firebase project, you accept the Firebase Extensions User Terms of Service: https://firebase.google.com/terms/extensions/user
✔  extensions Successfully validated create for delete-user-data
i  extensions: Creating delete-user-data extension instance
✔  extensions Successfully created delete-user-data

✔  Deploy complete!

Sample Commands

@aalej aalej requested a review from joehan January 31, 2025 17:48
@joehan joehan enabled auto-merge (squash) February 4, 2025 00:11
@joehan joehan merged commit f32769b into master Feb 4, 2025
@joehan joehan deleted the aalej-ext-csb-name branch February 4, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants