Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- Increase emulator UI body parser limit to match Storage emulator maximum. (#8329)
- Fixed Data Connect setup issues for fresh databases due to IAM user not being created. (#8335)
- Fixed an issue where `ext:install` used POSIX file seperators on Windows machines. (#8326)
- Updated the Firebase Data Connect local toolkit to v1.9.2, which adds support for generated Angular SDKs and updates Dart SDK fields to follow best practices. (#8347)
- Fixed an issue where credentials from `firebase login` would not be correctly provided to the Data Connect emulator.
- Updated the Firebase Data Connect local toolkit to v1.9.1, which adds support for generated Angular SDKs and updates Dart SDK fields to follow best practices. (#8340)
- Fixed misleading comments in `firebase init dataconnect` `connector.yaml` template.
- Improved Data Connect SQL permissions to better handle tables owned by IAM roles. (#8339)
14 changes: 7 additions & 7 deletions src/emulator/downloadableEmulators.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const lsofi = require("lsofi");

Check warning on line 1 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe assignment of an `any` value

Check warning on line 1 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Require statement not part of import statement
import {
Emulators,
DownloadableEmulators,
Expand Down Expand Up @@ -59,20 +59,20 @@
dataconnect:
process.platform === "darwin" // macos
? {
version: "1.9.1",
version: "1.9.2",
expectedSize: 26403584,
expectedChecksum: "d128def81e45a3cbce8572f637b1c095",
expectedChecksum: "a0a957bb5d564059ed883fee9e9fd67a",
}
: process.platform === "win32" // windows
? {
version: "1.9.1",
expectedSize: 26846720,
expectedChecksum: "0ba82416937d503f8559f14271eb62f6",
version: "1.9.2",
expectedSize: 26846208,
expectedChecksum: "80f49b574aa69ef76fb49e2e96c8a699",
}
: {
version: "1.9.1", // linux
version: "1.9.2", // linux
expectedSize: 26316952,
expectedChecksum: "0a8d1685c5de074959574e8aabb8153b",
expectedChecksum: "cc3c0318e453d9ddf098b582ee0f2b77",
},
};

Expand Down Expand Up @@ -274,7 +274,7 @@
shell: false,
},
pubsub: {
binary: `${getExecPath(Emulators.PUBSUB)!}`,

Check warning on line 277 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Forbidden non-null assertion
args: [],
optionalArgs: ["port", "host"],
joinArgs: true,
Expand Down Expand Up @@ -310,7 +310,7 @@
}

/**
* @param name

Check warning on line 313 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing JSDoc @param "name" description
*/
export function getLogFileName(name: string): string {
return `${name}-debug.log`;
Expand All @@ -323,7 +323,7 @@
*/
export function _getCommand(
emulator: DownloadableEmulators,
args: { [s: string]: any },

Check warning on line 326 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type
): DownloadableEmulatorCommand {
const baseCmd = Commands[emulator];
const defaultPort = Constants.getDefaultPort(emulator);
Expand All @@ -336,7 +336,7 @@
if (
baseCmd.binary === "java" &&
utils.isRunningInWSL() &&
(!args.host || !args.host.includes(":"))

Check warning on line 339 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe member access .includes on an `any` value

Check warning on line 339 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe call of an `any` typed value
) {
// HACK(https://github.com/firebase/firebase-tools-ui/issues/332): Force
// Java to use IPv4 sockets in WSL (unless IPv6 address explicitly used).
Expand All @@ -355,7 +355,7 @@
}

const argKey = "--" + key;
const argVal = args[key];

Check warning on line 358 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe assignment of an `any` value

if (argVal === undefined) {
logger.log("DEBUG", `Ignoring empty arg for key: ${key}`);
Expand All @@ -364,9 +364,9 @@

// Sigh ... RTDB emulator needs "--arg val" and PubSub emulator needs "--arg=val"
if (baseCmd.joinArgs) {
cmdLineArgs.push(`${argKey}=${argVal}`);

Check warning on line 367 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Invalid type "any" of template literal expression
} else {
cmdLineArgs.push(argKey, argVal);

Check warning on line 369 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe argument of type `any` assigned to a parameter of type `string`
}
});

Expand Down
Loading