Fixed issue where firebase init hosting re-prompts for source#8617
Merged
Fixed issue where firebase init hosting re-prompts for source#8617
Conversation
jamesdaniels
requested changes
May 16, 2025
src/init/features/hosting/index.ts
Outdated
| default: true, | ||
| }); | ||
| setup.hosting.useDiscoveredFramework = | ||
| setup.hosting.useDiscoveredFramework || |
Member
There was a problem hiding this comment.
You could simplify with ||= here for same effect but you really should be using ?? or ??= here since we want false to be a cachable value
Member
There was a problem hiding this comment.
Same feedback for other changed lines
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! Will update
jamesdaniels
approved these changes
May 19, 2025
joehan
approved these changes
May 22, 2025
TrCaM
pushed a commit
that referenced
this pull request
May 26, 2025
* Fixed issue where firebase init hosting re-prompts for source * Simplify and correct condition for determining when to prompt --------- Co-authored-by: joehan <joehanley@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8587
From what I can tell, the previous behavior of
promptOnceandpromptwas that, once a question has an answer, we no longer prompt for that question--- promptOnce
firebase-tools/src/prompt.ts
Lines 108 to 113 in 8cc734b
--- prompt
firebase-tools/src/prompt.ts
Lines 47 to 70 in 8cc734b
Scenarios Tested
Verified that the prompts behave the same as the old versions (14.2.2)
14.2.2 behavior
branch behavior
Sample Commands