npm list fallback, increase timeout to 60s

CHANGELOG.md

@@ -5,3 +5,5 @@
 - Always setup Data Connect SDK when FDC_CONNECTOR env var is set.
 - `firebase init` now uses FIREBASE_PROJECT env var as the default project name.
 - Add emulator support to firestore MCP tools. (#8700)
+- Increased npm timeout for web frameworks to 60s. (#8702)
+- Fallback to reading web framework dependencies version directly from node_modules package.json when the npm timeout is reached. (#8702)

src/frameworks/constants.ts

@@ -2,7 +2,7 @@
 import * as clc from "colorette";
 import * as experiments from "../experiments";
 
-export const NPM_COMMAND_TIMEOUT_MILLIES = 10_000;
+export const NPM_COMMAND_TIMEOUT_MILLIES = 60_000;
 
 export const SupportLevelWarnings = {
   [SupportLevel.Experimental]: (framework: string) => `Thank you for trying our ${clc.italic(
@@ -73,10 +73,10 @@
 
 export const I18N_ROOT = "/";
 
 export function GET_DEFAULT_BUILD_TARGETS() {
   return Promise.resolve(["production", "development"]);
 }
 
 export function DEFAULT_SHOULD_USE_DEV_MODE_HANDLE(target: string) {
   return Promise.resolve(target === "development");
 }

src/frameworks/utils.ts

@@ -1,4 +1,4 @@
-import { readJSON as originalReadJSON } from "fs-extra";
+import { readJSON as originalReadJSON, readJsonSync } from "fs-extra";
 import type { ReadOptions } from "fs-extra";
 import { dirname, extname, join, relative } from "path";
 import { readFile } from "fs/promises";
@@ -23,7 +23,7 @@
 
 // Use "true &&"" to keep typescript from compiling this file and rewriting
 // the import statement into a require
 const { dynamicImport } = require(true && "../dynamicImport");
 
 const NPM_ROOT_TIMEOUT_MILLIES = 5_000;
 const NPM_ROOT_MEMO = new Map<string, string>();
@@ -40,7 +40,7 @@
  *
  * Note: `throws: false` won't work with the async function: https://github.com/jprichardson/node-fs-extra/issues/542
  */
 export function readJSON<JsonType = any>(
   file: string,
   options?: ReadOptions | BufferEncoding | string,
 ): Promise<JsonType> {
@@ -57,8 +57,8 @@
   defaultBuildScripts: string[],
 ): Promise<void> {
   const packageJsonBuffer = await readFile(join(dir, "package.json"));
   const packageJson = JSON.parse(packageJsonBuffer.toString());
   const buildScript = packageJson.scripts?.build;
 
   if (buildScript && !defaultBuildScripts.includes(buildScript)) {
     console.warn(
@@ -290,8 +290,14 @@
     { cwd, env, timeout: NPM_COMMAND_TIMEOUT_MILLIES },
   );
   if (!result.stdout) return;
-  const json = JSON.parse(result.stdout.toString());
-  return scanDependencyTree(name, json.dependencies);
+  try {
+    const json = JSON.parse(result.stdout.toString());
+    return scanDependencyTree(name, json.dependencies);
+  } catch (e) {
+    // fallback to reading the version directly from package.json if npm list times out
+    const packageJson = readJsonSync(join(cwd, name, "package.json"), { throws: false });
+    return packageJson?.version ? { version: packageJson.version } : undefined;
+  }
 }
 
 export function relativeRequire(