Fix --help

[joehan]

Description

Fix --help in a bunch of cases where it was behaving badly:

firebase --help behaves like firebase help

firebase [command] --help behaves like firebase help [command]:

firebase help --help displays help text for the help command:

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and rectifies several inconsistencies in how the --help flag functions across the Firebase CLI. Previously, the --help flag did not always yield the expected help output, leading to a confusing user experience. The changes ensure that --help consistently acts as an alias for the help command, both for the main CLI and for individual subcommands, thereby standardizing and improving the accessibility of help documentation.

Highlights

• Improved Global Help: The firebase --help command now correctly behaves like firebase help, providing a consistent experience for users seeking general assistance.
• Enhanced Command-Specific Help: Using firebase [command] --help will now properly display the help text for that specific command, mirroring the behavior of firebase help [command].
• Corrected Help Command Help: The firebase help --help command now accurately shows the help text for the help command itself, resolving previous inconsistencies.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix several issues with the --help flag. The changes correctly handle showing help for specific commands (e.g., firebase <command> --help). However, I've found an issue with the implementation for the general firebase --help command, where it doesn't load all available commands, leading to incomplete help text. I've provided a suggestion to fix this and also to make the logic for command loading a bit more robust.

[gemini-code-assist]

This implementation has a couple of issues:

1. It doesn't correctly handle firebase --help. This should be treated as a general help command, which requires loading all commands to display them. The current logic fails to do so.
2. The client.getCommand(commandName) call is made even when commandName is an option (e.g., --help), which is not ideal.

I've refactored the logic to address both points. It now correctly identifies firebase --help as a help command and avoids calling getCommand with an option.

  const hasHelpFlag = args.includes("--help") || args.includes("-h");
  const isHelp =
    !args.length ||
    commandName === "help" ||
    (args.length === 1 && commandName === "ext") ||
    (args.length === 1 && hasHelpFlag);

  if (hasHelpFlag && commandName && !commandName.startsWith("-")) {
    client.getCommand(commandName);
  }

[joehan]

This is incorrect, as shown by the testing above.