-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore(devctr): update rust to 1.93 #5656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShadowCurse
wants to merge
5
commits into
firecracker-microvm:main
Choose a base branch
from
ShadowCurse:rust_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+87
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8fcd8b to
0547a32
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5656 +/- ##
==========================================
+ Coverage 83.23% 83.57% +0.33%
==========================================
Files 277 277
Lines 29316 29146 -170
==========================================
- Hits 24402 24358 -44
+ Misses 4914 4788 -126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1bd90de to
14f8e05
Compare
Update rust, cargo-deny and kani versions in devctr and update the rust-toolchain.toml Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Bump devctr version in the devtool Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
14f8e05 to
8307568
Compare
New rust version brought this commit: 426ab142507fca8704d934da556f1c96b0fd61b2 which updated `write` function for unix sockets to use `sendto` syscall. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
With new rust version and new bundled musl 1.2.5 these syscalls are no longer required. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Instead of fluding the console with debug logs from vsock and other places for all VMs, only do this for api tests. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
bc56f57 to
c031228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.